Repository navigation
Bump dependencies to fix security alerts - #263
Merged
Merged
Conversation
wu-sheng
force-pushed
the
bump/security-deps-2026-11
branch
4 times, most recently
from
November 2, 2026 11:08
e4a1231 to
8efff5e
Compare
Dependencies: - github.com/klauspost/compress v1.15.9 -> v1.18.7 in go.mod and plugins/core/go.mod (CVE-2026-63209, GHSA-259r-337f-4rfw). - golang.org/x/net v0.61.0 -> v0.62.0 in go.mod and plugins/core/go.mod (GO-2026-6860, GO-2026-6866, reported by govulncheck). - github.com/sirupsen/logrus v1.9.0 -> v1.9.4 in tools/go-agent/go.mod (CVE-2025-65637, GHSA-4f99-4q7p-p3gh). go get raises testify to v1.10.0, the version logrus v1.9.4 requires. - go.work.sum gains the x/net v0.61.0 go.mod checksum that the workspace still needs. CHANGES.md notes the bumps. License: - Regenerate dist/LICENSE and dist/licenses with license-eye v0.9.0 (dependency resolve on tools/go-agent/go.mod, GOWORK=off), the module the existing file was generated from. This moves logrus and testify, updates go-internal and golang.org/x/{mod,sys,text,tools} (stale since 2023), drops seven modules that tools/go-agent no longer requires (benbjohnson/clock, dave/jennifer, kr/text, sergi/go-diff, stretchr/objx, go.uber.org/goleak, golang.org/x/sync), refreshes the x/* license texts, and orders the license groups as the tool does. - Make that output reproducible from the repository: point .licenserc.yaml dependency.files at tools/go-agent/go.mod (it named the root go.mod, which is not what dist/LICENSE was ever built from) and commit the summary template as tools/release/LICENSE.tpl, outside dist/ because create_bin_release.sh copies dist/* into the binary release. Regenerate with: GOWORK=off license-eye dependency resolve --summary tools/release/LICENSE.tpl --license dist/LICENSE --output dist/licenses - Add dist/licenses to header paths-ignore. license-eye v0.9.0 matches paths-ignore against the full path, so the existing 'licenses' entry no longer covers dist/licenses and its header check fails on the third-party license texts; the pinned CI version is unaffected. GitHub Actions: - actions/checkout v2/v4 -> v7, actions/setup-go v2 -> v7 (cache: false keeps the v2 behavior), actions/upload-artifact v4 -> v7, actions/download-artifact v4 -> v8. - docker/login-action v4.6.0 -> v4.7.0; the v4.6.0 SHA expires on the ASF allow list on 2027-01-16. - apache/skywalking-infra-e2e 7e4b5b6 -> 56ac8be (current main). The old pin downloads docker-compose v1.29.2. - Plugin tests: run docker-compose through the runner's Compose v2 plugin instead of downloading the end-of-life Compose v1.29.2, since Docker 29 on ubuntu-26.04 raised the minimum API version it accepts. - Plugin test validators (validator.tpl, windows-validator.tpl): the health check runs under `set -e`, so the first probe that got no 200 (`STATUS=$(curl ... | grep ...)` exits 1) ended the validator instead of retrying, and kratosv2 failed whenever its HTTP server was not ready on the first probe. Add `|| true` so the existing retry loop actually retries.
wu-sheng
force-pushed
the
bump/security-deps-2026-11
branch
from
November 2, 2026 11:12
8efff5e to
bd2a268
Compare
CodePrometheus
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the vulnerable dependencies of the shipped modules (the agent module, the reporter
plugins/core, and thetools/go-agenttoolexec binary) and moves CI to the current ASF-approved action versions, so it keeps working on ubuntu-26.04 runners with Docker 29.Dependencies
github.com/klauspost/compress(indirect, via segmentio/kafka-go)go.mod,plugins/core/go.modgolang.org/x/net(indirect, via grpc)go.mod,plugins/core/go.modgithub.com/sirupsen/logrustools/go-agent/go.modgo getraises testify intools/go-agentto v1.10.0, the version logrus v1.9.4 requires.godirective: every new version builds on Go 1.26.0, so thego 1.26.0floor does not change.agent/reporter/imports.goimports kafka-go.go.work.sumadds thegolang.org/x/net v0.61.0/go.modchecksum, which the workspace still needs because other modules require that version.CHANGES.mdhas one line in the 0.8.0 Bug Fixes.tools/go-agentcannot be tidied withGOWORK=off, because it imports the plugin modules throughgo.workonly. Itsgo.mod/go.sumare the result ofgo get, without unrelated churn.License
dist LICENSE regenerated with license-eye v0.9.0 (
a196742f472feaffafea537ce5a2a4c3c53a8de4), replacing the hand-edited lines.9bd5feb, January 2021) only checks headers: it has no--summary/--output. I used the latest release and a template whose header is the existing text ofdist/LICENSE..licenserc.yamldependency.filesnamed the rootgo.mod, whichdist/LICENSEwas never built from; it now namestools/go-agent/go.mod. The template is committed astools/release/LICENSE.tpl, outsidedist/becausetools/release/create_bin_release.shcopiesdist/*into the binary release, and it is excluded from the header check. Regenerate with:GOWORK=off license-eye dependency resolve --summary tools/release/LICENSE.tpl --license dist/LICENSE --output dist/licenses(license-eye v0.9.0); the committed files match its output.dist/licensesis added to the header-checkpaths-ignore. license-eye v0.9.0 matchespaths-ignoreagainst the full path, so the existinglicensesentry no longer coversdist/licenses, and a v0.9.0 header check failed on 17 third-party license texts there (already the case onmain). With the entry it reports 645 valid, 0 invalid. The license-eye pinned in CI (9bd5feb) is unaffected.mainalready differs from the committed file, so most of this diff predates this PR: go-internal v1.10.0 -> v1.9.0, golang.org/x/mod v0.9.0 -> v0.42.0, x/sys v0.8.0 -> v0.49.0, x/text v0.9.0 -> v0.43.0, x/tools v0.7.0 -> v0.52.0, updated x/* license texts, and seven modules thattools/go-agentno longer requires are dropped (benbjohnson/clock, dave/jennifer, kr/text, sergi/go-diff, stretchr/objx, go.uber.org/goleak, golang.org/x/sync). The tool sorts the license groups, so their order changes too.skywalking-go-agentbinary built in the workspace links about 95 third-party modules through the plugin modules (go version -m), including grpc, golang.org/x/net and klauspost/compress, which this list (scoped totools/go-agent/go.mod) does not contain. The rootLICENSEdependency list is also from 2023. Both are left for a separate change.GitHub Actions
actions/*andapache/*are trusted owners in apache/infrastructure-actions. Third-party actions use SHAs listed inactions.yml.actions/checkoutv2 / v4 -> v7actions/setup-gov2 -> v7, withcache: falseso the v2 behavior (no dependency cache) does not change. Since v6, setup-go setsGOTOOLCHAIN=local. No module requires a Go newer than 1.26.0, so this is safe.actions/upload-artifactv4 -> v7actions/download-artifactv4 -> v8 (by-name downloads, so v5's by-ID path change does not apply)docker/login-actiondbcb813(v4.6.0, expires on the ASF allow list on 2027-01-16) ->81c6f93d4bc991e510b342a00b419b3bb4efc5c6# v4.7.0apache/skywalking-infra-e2e7e4b5b68716fdb7b79b21fa8908f9db497e1b115->56ac8befeb5f910f2dc9339e65d07cd18953f90e(current infra-e2e main, which apache/skywalking-java's E2E also uses on ubuntu-26.04). The old pin downloads docker-compose v1.29.2.apache/skywalking-eyes@9bd5feb(trusted owner, still on the v0 line).Docker 29 / ubuntu-26.04
docker-composewas missing. Compose v1 is end of life, and Docker 29 raised the minimum API version the daemon accepts (1.44 in 29.0), so the step now installs adocker-composewrapper that runs the runner's Compose v2 plugin. No run on ubuntu-26.04 has shown Compose v1 failing; this PR's CI shows whether the wrapper works.scenarios.tplalready handles Compose v2 (the-container name separator).if: false) macOS plugin job still pinsmacos-12, a runner that no longer exists, and still installs Compose v1. I left it unchanged because it never runs.test/plugins/runner-helper/templates/validator.tplandwindows-validator.tpl): the health check runs underset -e, so the first probe without a 200 (STATUS=$(curl ... | grep ...)exits 1) ended the validator instead of retrying. kratosv2 failed this way twice on this branch, in a different version each time, whenever its HTTP server was not ready on the first probe. Adding|| truemakes the existing retry loop actually retry.Verification (local, Go 1.27.1, darwin/arm64)
govulncheck(v1.9.0, DB 2026-10-27) in.,plugins/core(workspace andGOWORK=off) andtools/go-agent(workspace): before, x/net GO-2026-6860/GO-2026-6866 in all three. After, no third-party findings in.andplugins/core.go build ./...andgo test ./...pass in all three modules in workspace mode, and in.andplugins/corewithGOWORK=off.go mod tidyin.andplugins/coreleaves the tree clean (make check).skywalking-go-agentfrom the workspace, then built an app outside the workspace (GOWORK=off, agent replaced by this tree) that resolves compress v1.18.7, kafka-go v0.4.43 and x/net v0.62.0.-toolexecbuilds pass with the gRPC reporter and withSW_AGENT_REPORTER_TYPE=kafka, and the gRPC binary starts and exits cleanly.actionlintv1.7.12: the only findings are the pre-existing ones in the disabled macOS job (if: false,macos-12).CI note
The first CI run failed
TestConnectionManagerFailoverAfterActiveStopsinplugins/core/reporter(condition not met within 15s). The same test failed the same way on 2026-10-18 in run 39113605589, which did not have these bumps. Locally, 30 runs of it andTestMultiBackendCollectSendFailsOverAfterActiveStopspass on bothmainand this branch, with and without-race, and 10 runs of the whole reporter package withGOMAXPROCS=2and coverage pass on both. I treat it as an existing flaky test.Deliberately left
plugins/<framework>/go.mod),test/plugins/scenarios/**andtest/benchmark-codebase/**. Those versions are compile-only or compatibility targets.go.modname packages that it does not require (gin, fiber, go-git, pgx, amqp091-go, ...), or versions below the ones it requires (grpc, x/net, protobuf). Dependabot attributes the workspace module graph to the root manifest. For example, #988 recordsklauspost/compress = v1.13.6, which comes fromtest/plugins/scenarios/mongo. These alerts can only change with the plugin and scenario modules, so #988 may stay open after this PR.golang.org/x/cryptoGO-2026-5932 (openpgp, no fixed version) appears only in thetools/go-agentworkspace build list, through plugin modules. Nothing calls it.setup-goinstalls the latest patch release, and thegodirective is not raised.No open Dependabot PRs are covered.