Skip to content

Bump dependencies to fix security alerts - #263

Merged
wu-sheng merged 1 commit into
mainfrom
bump/security-deps-2026-11
Nov 2, 2026
Merged

wu-sheng merged 1 commit into
mainfrom
bump/security-deps-2026-11

Conversation

@wu-sheng

@wu-sheng wu-sheng commented Nov 2, 2026 •

Copy link
Copy Markdown
Member

Bumps the vulnerable dependencies of the shipped modules (the agent module, the reporter plugins/core, and the tools/go-agent toolexec binary) and moves CI to the current ASF-approved action versions, so it keeps working on ubuntu-26.04 runners with Docker 29.

Dependencies

Package Old New Manifests Advisories
github.com/klauspost/compress (indirect, via segmentio/kafka-go) v1.15.9 v1.18.7 go.mod, plugins/core/go.mod GHSA-259r-337f-4rfw / CVE-2026-63209 (alerts #988, #989)
golang.org/x/net (indirect, via grpc) v0.61.0 v0.62.0 go.mod, plugins/core/go.mod GO-2026-6860, GO-2026-6866 (reported by govulncheck)
github.com/sirupsen/logrus v1.9.0 v1.9.4 tools/go-agent/go.mod GHSA-4f99-4q7p-p3gh / CVE-2025-65637 (alert #372)
  • v1.18.7 is the lowest klauspost/compress release with the fix. logrus v1.9.4 is the latest v1.9.x patch, and it is the version the workspace already selects. go get raises testify in tools/go-agent to v1.10.0, the version logrus v1.9.4 requires.
  • No new go directive: every new version builds on Go 1.26.0, so the go 1.26.0 floor does not change.
  • The root module's requirement sets the minimum compress version that applications importing the agent get, because agent/reporter/imports.go imports kafka-go.
  • go.work.sum adds the golang.org/x/net v0.61.0/go.mod checksum, which the workspace still needs because other modules require that version. CHANGES.md has one line in the 0.8.0 Bug Fixes.
  • tools/go-agent cannot be tidied with GOWORK=off, because it imports the plugin modules through go.work only. Its go.mod/go.sum are the result of go get, without unrelated churn.

License

dist LICENSE regenerated with license-eye v0.9.0 (a196742f472feaffafea537ce5a2a4c3c53a8de4), replacing the hand-edited lines.

  • The repository had no committed generation command or template, and the license-eye pinned in CI (9bd5feb, January 2021) only checks headers: it has no --summary/--output. I used the latest release and a template whose header is the existing text of dist/LICENSE.
  • The output is now reproducible from the repository. .licenserc.yaml dependency.files named the root go.mod, which dist/LICENSE was never built from; it now names tools/go-agent/go.mod. The template is committed as tools/release/LICENSE.tpl, outside dist/ because tools/release/create_bin_release.sh copies dist/* into the binary release, and it is excluded from the header check. Regenerate with: GOWORK=off license-eye dependency resolve --summary tools/release/LICENSE.tpl --license dist/LICENSE --output dist/licenses (license-eye v0.9.0); the committed files match its output.
  • dist/licenses is added to the header-check paths-ignore. license-eye v0.9.0 matches paths-ignore against the full path, so the existing licenses entry no longer covers dist/licenses, and a v0.9.0 header check failed on 17 third-party license texts there (already the case on main). With the entry it reports 645 valid, 0 invalid. The license-eye pinned in CI (9bd5feb) is unaffected.
  • Running the same command on unmodified main already differs from the committed file, so most of this diff predates this PR: go-internal v1.10.0 -> v1.9.0, golang.org/x/mod v0.9.0 -> v0.42.0, x/sys v0.8.0 -> v0.49.0, x/text v0.9.0 -> v0.43.0, x/tools v0.7.0 -> v0.52.0, updated x/* license texts, and seven modules that tools/go-agent no longer requires are dropped (benbjohnson/clock, dave/jennifer, kr/text, sergi/go-diff, stretchr/objx, go.uber.org/goleak, golang.org/x/sync). The tool sorts the license groups, so their order changes too.
  • This PR's own change on top of that is logrus v1.9.0 -> v1.9.4 and testify v1.8.2 -> v1.10.0.
  • Not covered, before or after this PR: the skywalking-go-agent binary built in the workspace links about 95 third-party modules through the plugin modules (go version -m), including grpc, golang.org/x/net and klauspost/compress, which this list (scoped to tools/go-agent/go.mod) does not contain. The root LICENSE dependency list is also from 2023. Both are left for a separate change.

GitHub Actions

actions/* and apache/* are trusted owners in apache/infrastructure-actions. Third-party actions use SHAs listed in actions.yml.

  • actions/checkout v2 / v4 -> v7
  • actions/setup-go v2 -> v7, with cache: false so the v2 behavior (no dependency cache) does not change. Since v6, setup-go sets GOTOOLCHAIN=local. No module requires a Go newer than 1.26.0, so this is safe.
  • actions/upload-artifact v4 -> v7
  • actions/download-artifact v4 -> v8 (by-name downloads, so v5's by-ID path change does not apply)
  • docker/login-action dbcb813 (v4.6.0, expires on the ASF allow list on 2027-01-16) -> 81c6f93d4bc991e510b342a00b419b3bb4efc5c6 # v4.7.0
  • apache/skywalking-infra-e2e 7e4b5b68716fdb7b79b21fa8908f9db497e1b115 -> 56ac8befeb5f910f2dc9339e65d07cd18953f90e (current infra-e2e main, which apache/skywalking-java's E2E also uses on ubuntu-26.04). The old pin downloads docker-compose v1.29.2.
  • Unchanged: apache/skywalking-eyes@9bd5feb (trusted owner, still on the v0 line).

Docker 29 / ubuntu-26.04

  • Plugin tests downloaded docker-compose v1.29.2 when docker-compose was missing. Compose v1 is end of life, and Docker 29 raised the minimum API version the daemon accepts (1.44 in 29.0), so the step now installs a docker-compose wrapper that runs the runner's Compose v2 plugin. No run on ubuntu-26.04 has shown Compose v1 failing; this PR's CI shows whether the wrapper works. scenarios.tpl already handles Compose v2 (the - container name separator).
  • The disabled (if: false) macOS plugin job still pins macos-12, a runner that no longer exists, and still installs Compose v1. I left it unchanged because it never runs.
  • The Windows plugin test installs Docker from the Docker apt repository and docker-compose v2.24.5 inside WSL. Both work with API 1.44, so that job is unchanged.
  • Plugin test validators (test/plugins/runner-helper/templates/validator.tpl and windows-validator.tpl): the health check runs under set -e, so the first probe without a 200 (STATUS=$(curl ... | grep ...) exits 1) ended the validator instead of retrying. kratosv2 failed this way twice on this branch, in a different version each time, whenever its HTTP server was not ready on the first probe. Adding || true makes the existing retry loop actually retry.

Verification (local, Go 1.27.1, darwin/arm64)

  • govulncheck (v1.9.0, DB 2026-10-27) in ., plugins/core (workspace and GOWORK=off) and tools/go-agent (workspace): before, x/net GO-2026-6860/GO-2026-6866 in all three. After, no third-party findings in . and plugins/core.
  • go build ./... and go test ./... pass in all three modules in workspace mode, and in . and plugins/core with GOWORK=off.
  • go mod tidy in . and plugins/core leaves the tree clean (make check).
  • Instrumented compile check: I built skywalking-go-agent from the workspace, then built an app outside the workspace (GOWORK=off, agent replaced by this tree) that resolves compress v1.18.7, kafka-go v0.4.43 and x/net v0.62.0. -toolexec builds pass with the gRPC reporter and with SW_AGENT_REPORTER_TYPE=kafka, and the gRPC binary starts and exits cleanly.
  • actionlint v1.7.12: the only findings are the pre-existing ones in the disabled macOS job (if: false, macos-12).
  • Not run locally: plugin scenario tests, E2E and the Windows job (they need Docker on Linux runners), and the Go 1.26 builds. CI on this PR covers them.

CI note

The first CI run failed TestConnectionManagerFailoverAfterActiveStops in plugins/core/reporter (condition not met within 15s). The same test failed the same way on 2026-10-18 in run 39113605589, which did not have these bumps. Locally, 30 runs of it and TestMultiBackendCollectSendFailsOverAfterActiveStops pass on both main and this branch, with and without -race, and 10 runs of the whole reporter package with GOMAXPROCS=2 and coverage pass on both. I treat it as an existing flaky test.

Deliberately left

  • Alerts on framework plugin modules (plugins/<framework>/go.mod), test/plugins/scenarios/** and test/benchmark-codebase/**. Those versions are compile-only or compatibility targets.
  • Many open alerts on the root go.mod name packages that it does not require (gin, fiber, go-git, pgx, amqp091-go, ...), or versions below the ones it requires (grpc, x/net, protobuf). Dependabot attributes the workspace module graph to the root manifest. For example, #988 records klauspost/compress = v1.13.6, which comes from test/plugins/scenarios/mongo. These alerts can only change with the plugin and scenario modules, so #988 may stay open after this PR.
  • golang.org/x/crypto GO-2026-5932 (openpgp, no fixed version) appears only in the tools/go-agent workspace build list, through plugin modules. Nothing calls it.
  • Go standard library advisories that govulncheck reports for the local go1.27.1 toolchain are fixed in go1.27.2/go1.27.3. CI's setup-go installs the latest patch release, and the go directive is not raised.

No open Dependabot PRs are covered.

@wu-sheng wu-sheng added the dependencies Pull requests that update a dependency file label Nov 2, 2026
@wu-sheng wu-sheng added this to the 0.8.0 milestone Nov 2, 2026
@wu-sheng
wu-sheng force-pushed the bump/security-deps-2026-11 branch 4 times, most recently from e4a1231 to 8efff5e Compare November 2, 2026 11:08
Dependencies:
- github.com/klauspost/compress v1.15.9 -> v1.18.7 in go.mod and
  plugins/core/go.mod (CVE-2026-63209, GHSA-259r-337f-4rfw).
- golang.org/x/net v0.61.0 -> v0.62.0 in go.mod and plugins/core/go.mod
  (GO-2026-6860, GO-2026-6866, reported by govulncheck).
- github.com/sirupsen/logrus v1.9.0 -> v1.9.4 in tools/go-agent/go.mod
  (CVE-2025-65637, GHSA-4f99-4q7p-p3gh). go get raises testify to
  v1.10.0, the version logrus v1.9.4 requires.
- go.work.sum gains the x/net v0.61.0 go.mod checksum that the
  workspace still needs. CHANGES.md notes the bumps.

License:
- Regenerate dist/LICENSE and dist/licenses with license-eye v0.9.0
  (dependency resolve on tools/go-agent/go.mod, GOWORK=off), the module
  the existing file was generated from. This moves logrus and testify,
  updates go-internal and golang.org/x/{mod,sys,text,tools} (stale
  since 2023), drops seven modules that tools/go-agent no longer
  requires (benbjohnson/clock, dave/jennifer, kr/text, sergi/go-diff,
  stretchr/objx, go.uber.org/goleak, golang.org/x/sync), refreshes the
  x/* license texts, and orders the license groups as the tool does.
- Make that output reproducible from the repository: point
  .licenserc.yaml dependency.files at tools/go-agent/go.mod (it named
  the root go.mod, which is not what dist/LICENSE was ever built from)
  and commit the summary template as tools/release/LICENSE.tpl, outside
  dist/ because create_bin_release.sh copies dist/* into the binary
  release. Regenerate with:
  GOWORK=off license-eye dependency resolve --summary tools/release/LICENSE.tpl --license dist/LICENSE --output dist/licenses
- Add dist/licenses to header paths-ignore. license-eye v0.9.0 matches
  paths-ignore against the full path, so the existing 'licenses' entry
  no longer covers dist/licenses and its header check fails on the
  third-party license texts; the pinned CI version is unaffected.

GitHub Actions:
- actions/checkout v2/v4 -> v7, actions/setup-go v2 -> v7 (cache: false
  keeps the v2 behavior), actions/upload-artifact v4 -> v7,
  actions/download-artifact v4 -> v8.
- docker/login-action v4.6.0 -> v4.7.0; the v4.6.0 SHA expires on the
  ASF allow list on 2027-01-16.
- apache/skywalking-infra-e2e 7e4b5b6 -> 56ac8be (current main). The
  old pin downloads docker-compose v1.29.2.
- Plugin tests: run docker-compose through the runner's Compose v2
  plugin instead of downloading the end-of-life Compose v1.29.2, since
  Docker 29 on ubuntu-26.04 raised the minimum API version it accepts.
- Plugin test validators (validator.tpl, windows-validator.tpl): the
  health check runs under `set -e`, so the first probe that got no 200
  (`STATUS=$(curl ... | grep ...)` exits 1) ended the validator instead
  of retrying, and kratosv2 failed whenever its HTTP server was not
  ready on the first probe. Add `|| true` so the existing retry loop
  actually retries.
@wu-sheng
wu-sheng merged commit 7c664b5 into main Nov 2, 2026
49 checks passed
@wu-sheng
wu-sheng deleted the bump/security-deps-2026-11 branch November 2, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants